Skip to content

Commit

Permalink
Fixes #1282: Consider to adopt new createStatusBarItem API for id and…
Browse files Browse the repository at this point in the history
… name properties
  • Loading branch information
dbaeumer committed Jun 16, 2021
1 parent 62c41bd commit c273e04
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
14 changes: 7 additions & 7 deletions client/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"vscode": "^1.53.0"
},
"devDependencies": {
"@types/vscode": "1.53.0"
"@types/vscode": "1.57.0"
},
"dependencies": {
"vscode-languageclient": "7.0.0"
Expand Down
2 changes: 1 addition & 1 deletion client/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@ class Migration {

function realActivate(context: ExtensionContext): void {

const statusBarItem = Window.createStatusBarItem(StatusBarAlignment.Right, 0);
const statusBarItem = Window.createStatusBarItem('generalStatus', StatusBarAlignment.Right, 0);
let serverRunning: boolean | undefined;

This comment has been minimized.

Copy link
@bpasero

bpasero Jun 16, 2021

Member

@dbaeumer I think you missed to add a name, the identifier is one part of it, the name is for showing in the menu.

This comment has been minimized.

Copy link
@dbaeumer

dbaeumer Jun 16, 2021

Author Member

@bpasero I got confused with text and name. Do you fall back to the text if no name is provided.

This comment has been minimized.

Copy link
@bpasero

bpasero Jun 16, 2021

Member

@dbaeumer text is for the thing that is being displayed in the status bar and will not be used for the menu. name is used only in the menu and if not provided, we just show the extension name.

This comment has been minimized.

Copy link
@bpasero

bpasero Jun 16, 2021

Member

To clarify:

  • text could be: "50 problems found in project"
  • name then could be: "Problems Metrics"

This comment has been minimized.

Copy link
@dbaeumer

dbaeumer Jun 16, 2021

Author Member

@bpasero thanks for the clarification. Makes total sense.


const starting = 'ESLint server is starting.';
Expand Down

0 comments on commit c273e04

Please sign in to comment.