Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #1837

Closed
wants to merge 1 commit into from
Closed

Performance improvements #1837

wants to merge 1 commit into from

Conversation

DonJayamanne
Copy link

@DonJayamanne
Copy link
Author

Though this makes things fast, I do not believe this is the root cause,
This code path is getting hit when we execute cells in a notebook,
At this points the text documsnts of the cells do not change, hence I do not think eslint should fire.

Also shouldn't the condition here be changed from
if (Languages.match(packageJsonFilter, document) || Languages.match(configFileFilter, document) || validator.check(document) !== Validate.off) {

to

if ((Languages.match(packageJsonFilter, document) || Languages.match(configFileFilter, document)) && validator.check(document) !== Validate.off) {

Perhaps I've miunserstood the code or just don't understand it, but if the cell language is Python I would have expected this path to bail early on, instead of even going into the validator.check.

@dbaeumer
Copy link
Member

Closing. Performance improvements have been implemented in the LSP libs.

@dbaeumer dbaeumer closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants