Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce usage of * in vscode-extension-samples #762

Open
1 of 11 tasks
joyceerhl opened this issue Nov 17, 2022 · 1 comment · May be fixed by #981
Open
1 of 11 tasks

Reduce usage of * in vscode-extension-samples #762

joyceerhl opened this issue Nov 17, 2022 · 1 comment · May be fixed by #981
Assignees

Comments

@joyceerhl
Copy link
Contributor

joyceerhl commented Nov 17, 2022

There are currently 11 sample extensions which are * activated. We should update them to not be * activated:

11 rësµlts - 11 fïlës

  • basic-multi-root-sample\package.json:
    18 ],
    19: "activationEvents": [
    20: "*"
    21 ],

  • codelens-sample\package.json:
    18 ],
    19: "activationEvents": [
    20: "*"
    21 ],

  • comment-sample\package.json:
    18 ],
    19: "activationEvents": [
    20: "*"
    21 ],

  • completions-sample\package.json:
    17 ],
    18: "activationEvents": [
    19: "*"
    20 ],

  • decorator-sample\package.json:
    15 ],
    16: "activationEvents": [
    17: "*"
    18 ],

  • diagnostic-related-information-sample\package.json:
    18 ],
    19: "activationEvents": [
    20: "*"
    21 ],

  • github-authentication-sample\package.json:
    18 ],
    19: "activationEvents": [
    20: "*"
    21 ],

  • inline-completions\package.json:
    16 ],
    17: "activationEvents": [
    18: "*"
    19 ],

  • progress-sample\package.json:
    21 ],
    22: "activationEvents": [
    23: "*"
    24 ],

  • statusbar-sample\package.json:
    21 ],
    22: "activationEvents": [
    23: "*"
    24 ],

  • vim-sample\package.json:
    18 ],
    19: "activationEvents": [
    20: "*"
    21 ],

@apupier apupier linked a pull request Mar 7, 2024 that will close this issue
apupier added a commit to apupier/vscode-extension-samples that referenced this issue Mar 7, 2024
@TylerLeonhardt TylerLeonhardt assigned hediet and mjbvz and unassigned TylerLeonhardt Jul 24, 2024
@TylerLeonhardt
Copy link
Member

Not sure exactly who owns these things so just went general

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants