Sample test runner for microsoft/vscode-extension-vscode#157 #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits:
useColors
are deprecated in Mocha 5)mocha.opts
automatically resolvedprocess.stdout
which in Extension Host context is not available. Jest / create-react-app uses spawn and AVA need child process as wellvscode-test
doesn't need to depend on mocha. mocha should really be the extension's dev dependency.I suggest that we standardize the
run
signature, much as we do foractivate
of extensions. Its current form has many problems:testsRoot
is absolute path to the test runner. Not very useful.failures
has hidden logic for determining success/fail. I suggest plainthrow Error
for failures.vscode
is available through import in test files. Now since the tests run in another processvscode
is not available...Is it possible to support this? If not I'll drop thechild_process
part, but that takes away all benefits above.I suggest something like below:
@bpasero What do you think?