Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickInput : Add an example of prompt with history #89

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

AdrieanKhisbe
Copy link

I started to prototype a prompt with history, in order to improve prompting of command in VscodeVim.

Here is what I came up with.
I opened a PR to receive feedback and maybe if you wish incorporate it in the Quick Input sample

It is based on a QuickPick and record commands to a dedicated file.
Improvement could be made (max number of item notably), but this is a working MVP.

Thanks in advance for your feedbacks

@msftclas
Copy link

msftclas commented Aug 29, 2018

CLA assistant check
All CLA requirements met.

@AdrieanKhisbe
Copy link
Author

AdrieanKhisbe commented Sep 4, 2018

Thanks for your feedback @chrmarti. :)
Will dive into it very soon.

@AdrieanKhisbe AdrieanKhisbe force-pushed the prototype-prompt-with-history branch from bfbd137 to 136dc25 Compare March 31, 2019 14:40
@AdrieanKhisbe
Copy link
Author

Hey @chrmarti,
I at last applied your recommendations! :)
extension.globalState was indeed the way to go

@chrmarti chrmarti added this to the April 2019 milestone Apr 1, 2019
@chrmarti chrmarti modified the milestones: April 2019, May 2019 May 9, 2019
@chrmarti chrmarti modified the milestones: May 2019, June 2019 May 31, 2019
@chrmarti chrmarti modified the milestones: June 2019, On Deck Jun 24, 2019
@AdrieanKhisbe
Copy link
Author

@chrmarti I see there is a conflict, I can rebase to solve it if you ask me to. :)

@AdrieanKhisbe AdrieanKhisbe force-pushed the prototype-prompt-with-history branch from 136dc25 to 9bb3238 Compare October 11, 2019 09:09
@AdrieanKhisbe
Copy link
Author

Hello @chrmarti, gentle reminder after solving the conflict :)

quickinput-sample/src/promptCommandWithHistory.ts Outdated Show resolved Hide resolved
quickinput-sample/src/promptCommandWithHistory.ts Outdated Show resolved Hide resolved
quickinput-sample/src/promptCommandWithHistory.ts Outdated Show resolved Hide resolved
quickinput-sample/src/promptCommandWithHistory.ts Outdated Show resolved Hide resolved
@chrmarti
Copy link
Contributor

@AdrieanKhisbe Thanks for the update. I have added a few comments. (Sorry for the delay.)

@AdrieanKhisbe
Copy link
Author

@AdrieanKhisbe Thanks for the update. I have added a few comments. (Sorry for the delay.)

Thanks for the review @chrmarti!
(Don't worry, there wasn't any hurry :))

I just took into account your feedback, tell me if I misunderstood something.

@AdrieanKhisbe
Copy link
Author

@chrmarti and here it is :)

@AdrieanKhisbe AdrieanKhisbe requested a review from chrmarti March 9, 2020 21:55
Base automatically changed from master to main February 22, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants