-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuickInput : Add an example of prompt with history #89
base: main
Are you sure you want to change the base?
QuickInput : Add an example of prompt with history #89
Conversation
e26209d
to
c4978ea
Compare
Thanks for your feedback @chrmarti. :) |
bfbd137
to
136dc25
Compare
Hey @chrmarti, |
@chrmarti I see there is a conflict, I can rebase to solve it if you ask me to. :) |
136dc25
to
9bb3238
Compare
Hello @chrmarti, gentle reminder after solving the conflict :) |
@AdrieanKhisbe Thanks for the update. I have added a few comments. (Sorry for the delay.) |
Thanks for the review @chrmarti! I just took into account your feedback, tell me if I misunderstood something. |
@chrmarti and here it is :) |
I started to prototype a prompt with history, in order to improve prompting of command in VscodeVim.
Here is what I came up with.
I opened a PR to receive feedback and maybe if you wish incorporate it in the Quick Input sample
It is based on a QuickPick and record commands to a dedicated file.
Improvement could be made (max number of item notably), but this is a working MVP.
Thanks in advance for your feedbacks