Go to Type Definition will show a prompt to update guru when used on something that doesn't have a type

[segevfiner]

Steps to Reproduce:

1. Use "Go to Type Definition" on something that is not a type. For example, use it on Println in the following:

package main

import "fmt"

func main() {
	fmt.Println("Hello, World!")
}

2. You get the following:
   

Using it on something that has a type works correctly.

VS Code 1.29.1
vscode-go 0.7.1-beta.3

[ramya-rao-a]

Thanks for reporting @segevfiner

@hummerd, @segevfiner Our current method of identifying guru being stale seem to be catching a lot of false positives. Can any of you provide more information on the guru support here?

• Is it that guru describe is the new feature or the fact that guru describe providing the position of the type in the new feature.
• When was this feature of type position added to guru?

I'd rather us not show any prompt at all about updating guru, instead of showing it at wrong times.
I can add a note in the FAQ about updating guru to ensure this feature works.

[segevfiner]

It's this commit: golang/tools@9c8bd46 (I think). It adds the required information to the existing describe command.

[hummerd]

Type position is the new feature. I think extension can not separate this false cases from real ones - missing type position case (with old guru). Rest of guru's output is the same. So if we don't want this we should disable promtToUpdate at all. :(

[hummerd]

Here is PR #2172 for logging instead of prompt

[ramya-rao-a]

Thanks @segevfiner!

@hummerd, I didnt know you had implemented the feature in guru, nice job!

[ramya-rao-a]

@hummerd Can we expect the typepos property to exist in newer guru all the time event if the value is null/undefined?

If yes, then we can check guruOutput.value && !guruOutput.value.hasOwnProperty('typepos') to decide if we want to update the guru?

[hummerd]

Nop. We need patch guru for it. From guru's point of view it's ok. Why should it return values that are empty.

type DescribeValue struct {
	Type     string       `json:"type"`               // type of the expression
	Value    string       `json:"value,omitempty"`    // value of the expression, if constant
	ObjPos   string       `json:"objpos,omitempty"`   // location of the definition, if an Ident
	TypesPos []Definition `json:"typespos,omitempty"` // location of the named types, that type consist of
}

You can notice these omitempty tags on optional fields.

[hummerd]

Thanks @segevfiner!

@hummerd, I didnt know you had implemented the feature in guru, nice job!

Thanks :) It was a multi-step move.

[ramya-rao-a]

@segevfiner, @hummerd Can you confirm the fix using the latest beta version