Test Plan for December 2018 (0.8.0)

[ramya-rao-a]

If you got a notification from this issue, then you are part of the next update to the Go extension.
Thanks and Welcome!

Here I will be listing the features and the bug fixes that will go in the next update along with the the folks who logged the bugs/feature requests, those who upvoted it, and those who fixed it by sending PRs.

The idea is to get the folks behind this update to give the update a trial run before I release it.
Since I dont work with Go in my day job, I always feel that someone who does Go more than me can help in testing tremendously.

And when I say "test", you can do a minimum pass of just installing the update and then do nothing special other than going about using VS Code like you do everyday. Or you can test the feature you requested/implemented or the bug you logged/fixed. Or you can test all of the below. Every bit helps.

Drop in a comment in this issue after 2 or 3 days of installing the update with your findings.

• @Charliekenney23, @buyology

  • Support test functions with names Test, Example in codelens. Fixes Bug 2071 with PR 2072

• @brycekahle, @quchunguang, @radu-matei

  • Support setting of variables during debugging in the variable pane. Feature Request 1129 implemented with PR 2076

• @brycekahle, @willfaught, @eternal-flame-AD

  • Show pointer values during debugging in the variable pane. Feature Request 1989 implemented with PR 2075

• @brycekahle, @BlakeMScurr

  • Support the paging feature in stack traces during debugging. Feature Request 946 implemented with PR 2080

• @segevfiner

  • Avoid duplicate diagnostics when using tasks with build on save feature. Fixes Bug 2100 with PR 2109

• @segevfiner, @virtuald

  • Use dlv from the path set in the go.toolsGopath setting. Fixes Bug 2099 with PR 2108

• @karthikraobr

  • Differentiate structs from interfaces in the outline view. PR 2114

• @hummerd, @segevfiner, @nezorflame

  • Support the Go to Type Definition & Peek to Type Definition commands. Feature Request 2121 implemented with PR 2136

• @oneslash

  • Fix error that shows up when typing if no packages are found. Fixes Bug 2134 with PR 2135

• @Ashniu123

  • Rebuild the package after running Go: Get Package to get rid of the missing import errors. Fixes Bug 2087 with PR 2129

• @stamblerre, @nezorflame, @gencer

  • Support auto-completion when GO111MODULE is explicitly set. Fixes Bug 1944 with PR 2156

• @JPMoresmau

  • Fix bug where tests from another file are run due to partial match of function names. Fixes Bug 2144 with PR 2155

• @zmb3, @ssergiienko, @oneslash

  • Close the gocode daemon when closing VS Code. Fixes Bug 2132 with PR 2137

[oneslash]

#2134 - tested and works without error ✅

[nezorflame]

#2121 - works as expected. The only thing missing right now would be some predefined key combination, e.g. Ctrl + F12 or Cmd + F12 (on macOS)

[JPMoresmau]

Tested 2144, 2121 and 2114 and everything looked fine. Thanks. JP

…

On Mon, Dec 3, 2018 at 9:49 AM Ilya Danilkin ***@***.***> wrote: #2121 <#2121> - works as expected. The only thing missing right now would be some predefined key combination, e.g. Cmd + F12 (on macOS) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2164 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHdod2E-KWNUaZ7ApzrS6B3rJZES0cZks5u1OWqgaJpZM4Y9ROg> .

-- JP Moresmau http://jpmoresmau.blogspot.com/

[hummerd]

Some small fix for #2136 - #2167 :)

[segevfiner]

#2121 - works as expected. The only thing missing right now would be some predefined key combination, e.g. Ctrl + F12 or Cmd + F12 (on macOS)

"Go to Type definition" is a builtin command in VS Code. Once we add a provider for it, it shows up/becomes available. I don't think it would be right for this extension to add a default short cut for it, might want to open an issue on VS Code itself. But they seem quite apprehensive when it comes to adding new default keybindings. There are some really silly missing default keybinding, for example: "Join Lines", that is only bound in macOS, despite showing up quite prominently in the documentation.

[hummerd]

#2121 - works as expected. The only thing missing right now would be some predefined key combination, e.g. Ctrl + F12 or Cmd + F12 (on macOS)

It would be nice but:
Ctrl + F12 is already used for go to Implementation
And F12 is go to Definition
May be Ctrl + Shift + F12 ?

[karthikraobr]

2114 <#2114> works fine. Cheers, Kaarthik

…

On Sun, Dec 2, 2018 at 7:47 AM Ramya Rao ***@***.***> wrote: If you got a notification from this issue, then you are part of the next update to the Go extension. Thanks and Welcome! Here I will be listing the features and the bug fixes that will go in the next update along with the the folks who logged the bugs/feature requests, those who upvoted it, and those who fixed it by sending PRs. The idea is to get the folks behind this update to give the update a trial run before I release it. I always do basic testing before every update. But because I dont work with Go in my day job, I always feel that someone who does Go more than me can help in testing tremendously. And when I say "test", you can do a minimum pass of just installing the update and then do nothing special other than going about using VS Code like you do everyday. Or you can test the feature you requested/implemented or the bug you logged/fixed. Or you can test all of the below. Every bit helps. Drop in a comment in this issue after 2 or 3 days of installing the update <https://github.com/Microsoft/vscode-go/wiki/Use-the-beta-version-of-the-latest-Go-extension> with your findings. - @Charliekenney23 <https://github.com/Charliekenney23>, @buyology <https://github.com/buyology> - Support test functions with names Test, Example in codelens. Fixes Bug 2071 <#2071> with PR 2072 <#2072> - @brycekahle <https://github.com/brycekahle>, @quchunguang <https://github.com/quchunguang>, @radu-matei <https://github.com/radu-matei> - Support setting of variables during debugging in the variable pane. Feature Request 1129 <#1129> implemented with PR 2076 <#2076> - @brycekahle <https://github.com/brycekahle>, @willfaught <https://github.com/willfaught>, @eternal-flame-AD <https://github.com/eternal-flame-AD> - Show pointer values during debugging in the variable pane. Feature Request 1989 <#1989> implemented with PR 2075 <#2075> - @brycekahle <https://github.com/brycekahle>, @BlakeMScurr <https://github.com/BlakeMScurr> - Support the paging feature in stack traces during debugging. Feature Request 946 <#946> implemented with PR 2080 <#2080> - @segevfiner <https://github.com/segevfiner> - Avoid duplicate diagnostics when using tasks with build on save feature. Fixes Bug 2100 <#2100> with PR 2109 <#2109> - @segevfiner <https://github.com/segevfiner>, @virtuald <https://github.com/virtuald> - Use dlv from the path set in the go.toolsGopath setting. Fixes Bug 2099 <#2099> with PR 2108 <#2108> - @karthikraobr <https://github.com/karthikraobr> - Differentiate structs from interfaces in the outline view. PR 2114 <#2114> - @hummerd <https://github.com/hummerd>, @segevfiner <https://github.com/segevfiner>, @nezorflame <https://github.com/nezorflame> - Support the Go to Type Definition & Peek to Type Definition commands. Feature Request 2121 <#2121> implemented with PR 2136 <#2136> - @oneslash <https://github.com/oneslash> - Fix error that shows up when typing if no packages are found. Fixes Bug 2134 <#2134> with PR 2135 <#2135> - @Ashniu123 <https://github.com/Ashniu123> - Rebuild the package after running Go: Get Package to get rid of the missing import errors. Fixes Bug 2087 <#2087> with PR 2129 <#2129> - @stamblerre <https://github.com/stamblerre>, @nezorflame <https://github.com/nezorflame>, @gencer <https://github.com/gencer> - Support modules when GO111MODULE is explicitly set. Fixes Bug 1944 <#1944> with PR 2156 <#2156> - @JPMoresmau <https://github.com/JPMoresmau> - Fix bug where tests from another file are run due to partial match of function names. Fixes Bug 2144 <#2144> with PR 2155 <#2155> - @zmb3 <https://github.com/zmb3>, @ssergiienko <https://github.com/ssergiienko>, @oneslash <https://github.com/oneslash> - Close the gocode daemon when closing VS Code. Fixes Bug 2132 <#2132> with PR 2137 <#2137> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2164>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADm68nEqfRpUqbcM9Q9x8V_XWYbgB3nyks5u03eQgaJpZM4Y9ROg> .

[ramya-rao-a]

Thanks everyone!

Regarding the keyboard shortcut request for the Go to Type Definition command, @segevfiner is right. This is not a command that is specific to the Go extension. It is a generic feature like Go to definition or Find all references. Extensions implement the providers which provide the data. VS Code takes care of triggering, keyboard shortcuts, navigation, UI etc.

I would suggest to add your own keybinding or create a feature request in the vscode repo if you have any good ideas for it.

[eternal-flame-AD]

#1989 Looks great

[segevfiner]

#2100 #2099 seems working.

#2121 - See #2166 #2171

[stamblerre]

#1944 is working for me.

[willfaught]

#1989 worked for me, although the dereferenced pointer value is labeled with a single colon, which might be a bug. See the b variable below:

The debugger presentation of the pointer type seems incompatible with the other integral types (variables i and x in the example above). int(0) is displayed as i: 0, X(34) (where X is type X int) is displayed as x: 34, but (*int)(0xc0000160f8) is displayed as p: <*int>(0xc0000160f8). Maybe it makes sense to display it as just p: 0xc0000160f8 and let the user infer the type from the code like for the other variable types (and the presence of the drill down menu)?

[ramya-rao-a]

Thanks for reporting that @willfaught, can you log a new issue for that with the same details? We can use that for tracking the bug and possible fixes.

[willfaught]

@ramya-rao-a No problem. Done: #2176.

[nezorflame]

@ramya-rao-a as for the #1944, I still have some issues.

With "go.toolsEnvVars": { "GO111MODULE": "on" }, gocode-gomod is being launched now, which is good.
But, it still fails to give suggestions to the package functions before you save the file.

Update: moved the details to the new issue mentioned below.

[nezorflame]

I've created a new issue #2179 to investigate this particular problem.

[ramya-rao-a]

@nezorflame Yes #1944 initially started out as completions don't work without saving the file with the package used atleast once, but it moved on to the GO111MODULE issue.

stamblerre/gocode#3 is tracking the original issue. I'll update #1944

[ssergiienko]

@ramya-rao-a Done, #2132 works fine now, thx.

[ramya-rao-a]

Thanks everyone for all the help!
0.8.0 version of the Go extension has been released!