Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix buildFlags type in 'debug test' Codelens #1248

Merged
merged 2 commits into from
Oct 1, 2017
Merged

Fix buildFlags type in 'debug test' Codelens #1248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efc1d3d
Make `go.buildTags` pass correctly via Delve
ka2n Sep 27, 2017
8fb350d
Quote all build flags when passing to debug
ramya-rao-a Oct 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/goRunTestCodelens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ export class GoRunTestCodeLensProvider extends GoBaseCodeLensProvider {
let buildFlags = getTestFlags(vsConfig, null);
if (vsConfig['buildTags'] && buildFlags.indexOf('-tags') === -1) {
buildFlags.push('-tags');
buildFlags.push(`"${vsConfig['buildTags']}"`);
buildFlags.push(`${vsConfig['buildTags']}`);
}

let config = Object.assign({}, this.debugConfig, { args, program, env, envFile, buildFlags });
let config = Object.assign({}, this.debugConfig, { args, program, env, envFile, buildFlags: buildFlags.map(x => `'${x}'`).join(' ') });
let debugTestCmd: Command = {
title: 'debug test',
command: 'vscode.startDebug',
Expand Down