This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add auto test debug mode for launch.json (#1780)
#1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Aug 9, 2018
src/goDebugConfiguration.ts
Outdated
| let debugMode; | ||
| let testFileRegExp = RegExp('.*_test\.go$', 'g'); | ||
| const currentFileName = vscode.window.activeTextEditor.document.fileName; | ||
| if (testFileRegExp.test(currentFileName)) { |
There was a problem hiding this comment.
Isnt it simpler with if (activeEditor.document.fileName.endsWith('_test.go')) ?
I have a tendency to avoid regex when possible.
ramya-rao-a
suggested changes
Aug 9, 2018
check filename to get debug mode
prism4time
force-pushed
the
auto-test-debug-mode
branch
from
8cea511 to
39b3d17
Compare
ramya-rao-a
reviewed
Aug 10, 2018
src/goDebugConfiguration.ts
Outdated
| @@ -54,6 +54,12 @@ export class GoDebugConfigurationProvider implements vscode.DebugConfigurationPr | |||
| debugConfiguration['dlvLoadConfig'] = dlvConfig['dlvLoadConfig']; | |||
| } | |||
|
|
|||
| if (activeEditor.document.fileName.endsWith('_test.go')) { | |||
There was a problem hiding this comment.
The activeEditor can be null
ramya-rao-a
reviewed
Aug 10, 2018
src/goDebugConfiguration.ts
Outdated
| if (activeEditor.document.fileName.endsWith('_test.go')) { | ||
| debugConfiguration['mode'] = 'test'; | ||
| } else { | ||
| debugConfiguration['mode'] = 'debug'; |
There was a problem hiding this comment.
Do we really need the else here?
prism4time
force-pushed
the
auto-test-debug-mode
branch
from
5395b14 to
21d2e08
Compare
|
Fixes #1780 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use regex to check if the current file is for test