Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Remove env mask on GOOS and GOARCH #2015

Merged
merged 2 commits into from
Oct 17, 2018
Merged

Remove env mask on GOOS and GOARCH #2015

merged 2 commits into from
Oct 17, 2018

Conversation

eternal-flame-AD
Copy link
Contributor

@eternal-flame-AD eternal-flame-AD commented Oct 16, 2018 •
edited
Loading

Removed to allow suggestions on platform-specific syscall like syscall/js

WORK IN PROGRESS! Still undecided on how to resolve packages without precompiled objects.

@eternal-flame-AD eternal-flame-AD mentioned this pull request Oct 16, 2018
Closed
@stamblerre
Copy link
Contributor

If the user hasn't built their dependencies, then we really can't do better than using the -source flag. I've actually recently added a change to gocode that causes it to fall back to using -source if it can't find dependencies (mdempsky/gocode@a07fefd), so perhaps if you rebuild the latest version, that will work for you.

@ramya-rao-a
Copy link
Contributor

@eternal-flame-AD Can you run Go: Install/Update Tools, select gocode and press Ok to update it? Then try vscode with your changes and see if it works without needing to specifically installing the imports with the other GOOS?

@eternal-flame-AD
Copy link
Contributor Author

Yes, I think the problem is resolved now with the updated gocode:)

Remove env mask on GOOS and GOARCH
e11c6bd 
Removed to allow syggestions on platform-specific syscall

Revert "Ensure environment variables for gocode process are not configured for cross compilation"

This reverts commit f73f41d.
@ramya-rao-a
Copy link
Contributor

@eternal-flame-AD Last question: The changes in this PR are also needed for the problem to be fixed, correct? Or only updating gocode was enough?

@eternal-flame-AD
Copy link
Contributor Author

Yes, the change is needed because otherwise there would be of no way gocode could get the build context.

ramya-rao-a
ramya-rao-a approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @eternal-flame-AD!

Also, I see that this is your first contribution to vscode-go. Welcome & Thanks!
I hope that you have registered both for the Microsoft Hacktoberfest and the one from Digitalocean

Happy Coding!

@ramya-rao-a ramya-rao-a merged commit 0592a27 into microsoft:master Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eternal-flame-AD @stamblerre @ramya-rao-a