This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Show coverage for files when tests fails #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Jan 28, 2019
src/goCover.ts
Outdated
| @@ -305,7 +305,7 @@ export function toggleCoverageCurrentPackage() { | |||
| return goTest(testConfig).then(success => { | |||
| if (!success) { | |||
| showTestOutput(); | |||
| return []; | |||
| return applyCodeCoverageToAllEditors(tmpCoverPath, testConfig.dir); | |||
There was a problem hiding this comment.
We can skip this line altogether as we are returning the same outside this if block.
There was a problem hiding this comment.
Better this way!
I've commited the change
katakonst
force-pushed
the
show_cov_failed_test
branch
from
b45ddff
to
0f0ea00
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2193 by showing coverage in files even if the test fails