Unset GOBIN if go.toolsGopath is set

[jamesgeorge007]

Closes #2339
Unsets GOBIN environment variable if go.toolsGopath is set.

[jamesgeorge007]

@ramya-rao-a What do you suggest?

[ramya-rao-a]

@jamesgeorge007 Did you test it?

[jamesgeorge007]

@ramya-rao-a Well not really!
There were some sort of issues with my local environment and couldn't make to it 😕
Isn't this the exact position where you intended to unset GOBIN 🤔

[ramya-rao-a]

Yes, but when reviewing a PR, I also expect that the author has tested the changes to ensure that the fix actually fixes the problem as well :)

[jamesgeorge007]

@ramya-rao-a It doesn't seem to recognise vscode package despite running npm install while trying to set it up locally.
Also, why is the build failing?

[ramya-rao-a]

It doesn't seem to recognise vscode package despite running npm install

Do you see a vscode folder in your node_modules folder?
Does this have a vscode.d.ts file?

Also, why is the build failing?

The build is passing now, it was a flaky test that was failing for just 1 version.

[jamesgeorge007]

@ramya-rao-a It doesn't seem to exist in my case 🤔

What I can see is a thenable.d.ts file

[ramya-rao-a]

It doesn't seem to exist in my case

What is "it" referring to here? The vscode folder under the node_modules folder or the vscode.d.ts file?

[jamesgeorge007]

Pardon me for not making it clear

vscode directory seem to exist, while vscode.d.ts file doesn't!

[ramya-rao-a]

Can you share a screenshot of what does exist inside the vscode directory? In VS Code, expand the node_modules folder, then expand vscode and share a screenshot of the contents

Also try running npm run postinstall

[jamesgeorge007]

@ramya-rao Somehow got it right after trying out the postinstall script 👍

Currently all these sort of errors pops up :-

`

[ramya-rao-a]

@jamesgeorge007 I am not sure why you are getting those errors, it definitely looks like something is wrong with your setup. For eg: why would there be angular related packages in the node modules folder for vscode-go?

I am closing this PR as I am planning to fix the issue as part of something else I am working on.
Hope you are able to solve the dev environment issues, looking forward to other PRs from you.

Happy Coding!