This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Install tools with modules enabled #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Aug 16, 2019
ramya-rao-a
reviewed
Aug 16, 2019
ramya-rao-a
reviewed
Aug 16, 2019
ramya-rao-a
reviewed
Aug 26, 2019
ramya-rao-a
reviewed
Aug 26, 2019
src/goInstallTools.ts
Outdated
| const args = ['get', '-v']; | ||
| // Only get tools at master if we are not using modules. | ||
| if (modulesOff) { | ||
| args.push('-u'); |
There was a problem hiding this comment.
In module mode we don't need -u to get the latest?
There was a problem hiding this comment.
No, -u will update all of the dependencies, and in module mode, we just want to get the latest tagged version with the correct versions of the dependencies.
ramya-rao-a
approved these changes
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change installs the Go tools with modules enabled, if the user is on Go >= 1.11. The reason for this is to ensure that the user gets the latest tagged version for a tool, rather than the master (which can be unstable).
In particular, this is necessary for
gopls, since we have begun tagging stable versions. To avoid modifying the user'sgo.modfile (#1919), we run thego getcommand in a temporary directory.Fixes #2671