Include the link to release note/package overview in the update prompt, and update gopls default version #3041
Conversation
|
Can you add a screenshot of how this will look? |
src/goLanguageServer.ts
Outdated
| const defaultLatestVersion = semver.coerce('0.1.7'); | ||
| const defaultLatestVersionTime = moment('2019-09-18', 'YYYY-MM-DD'); | ||
| const defaultLatestVersion = semver.coerce('0.3.1'); | ||
| const defaultLatestVersionTime = moment('2020-02-04', 'YYYY-MM-DD'); |
There was a problem hiding this comment.
@ramya-rao-a: Can we get away from having this hardcoded default as a backup?
There was a problem hiding this comment.
We had this for the case when user doesnt want the extension to keep checking with the proxy server to determine if an update is needed. Removing the default would mean that such users will never get the prompt to update gopls
And once you click the Release Note, it will open a browser with the provided link. I wish I knew a way to let the prompt stay after clicking the link, so users can come back and click the Update button. |
|
Thanks! That looks really good. |
|
The update to gopls default version is ported to master branch via 36f0b58 and is part of 0.13.1 version of the extension |
|
There are a few linting errors, can you fix them?
|
Sync @ 7da5077 * master: Address mismatch on path separators in debug config (microsoft#2010) (microsoft#3108) Include the link to release note/package overview in the update prompt, and update gopls default version (microsoft#3041) bug_report.md: Fix "architecture" typo. (microsoft#3095) telemetry.ts: send telemetry only if aiKey is not an empty string(microsoft#3091)
Merge 'microsoft/vscode-go/master' into 'golang/vscode-go/master'
Sync @ 7da5077
* master:
Address mismatch on path separators in debug config (#2010) (#3108)
Include the link to release note/package overview in the update prompt, and update gopls default version (#3041)
bug_report.md: Fix "architecture" typo. (#3095)
telemetry.ts: send telemetry only if aiKey is not an empty string(#3091)
Change-Id: I727ef0ed3b8d1ad926e26831534c153b06070e64
GitHub-Last-Rev: d11e342
GitHub-Pull-Request: #11
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/224239
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
* master: goLanguageServer: set completion follow up command from middleware (microsoft#3084) Add stacktrace dump and better error messages on EXC_BAD_ACCESS panics (microsoft#2904) Address mismatch on path separators in debug config (microsoft#2010) (microsoft#3108) Include the link to release note/package overview in the update prompt, and update gopls default version (microsoft#3041) bug_report.md: Fix "architecture" typo. (microsoft#3095) telemetry.ts: send telemetry only if aiKey is not an empty string(microsoft#3091)
@stamblerre