Move away from deprecated language configuration settings #406
Conversation
|
Hi @aeschli, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| @@ -86,35 +86,7 @@ export function activate(ctx: vscode.ExtensionContext): void { | |||
| // ^.*\{[^}'']*$ | |||
| increaseIndentPattern: /^.*\{[^}'']*$/ | |||
| }, | |||
| wordPattern: /(-?\d*\.\d\w*)|([^\`\~\!\@\#\%\^\&\*\(\)\-\=\+\[\{\]\}\\\|\;\:\'\"\,\.\<\>\/\?\s]+)/g, | |||
There was a problem hiding this comment.
@aeschli I get that we are deleting comments, brackets, __electricCharachterSupport and __characterPairSupport because we have the language_configuration.json in the built-in extension "vscode.go"
But why are we deleting the wordPattern here?
|
Oh, that looks like a bug. |
|
Closing this in favor of #587 |
In the July release of VSCode we added new properties to the language configuration files so that the deprecated __characterPairSupport and __electricCharacterSupport APIs in vscode.d.ts are no longer necessary.
See microsoft/vscode#9281.
I've already added the comment, brackets and bracket pairs to the go language definition in the built-in go extension. See microsoft/vscode@8020da6
You can keep your current state a while if you want to be backward compatible to pre-July versions.