This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fix signature / hover provider (e.g. for struct fields) #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the usage of the `godoc` command to fetch the documentation of any element. Instead the source is inspected for comments above the definition or on the same line (like struct fields or interface methods).
guru works better for struct funcs. `guru definition` returns the location in the same format as before along with a single line definition (signature).
|
Hi @nochso, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #440.
guruis used to find the position of any definition instead ofgodefas it's more reliable.The definition lines are read straight from source.
Also
godocis no longer used to fetch the documentation, because querying it did not work in all cases.This is my first time working with TypeScript, so feel free to nitpick. I've tested all I could think of and it consistently provides useful hover information to me.