Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

export GoOutlineRange, GoOutlineDeclaration, GoOutlineOptions #803

Merged
merged 1 commit into from
Feb 15, 2017
Merged

export GoOutlineRange, GoOutlineDeclaration, GoOutlineOptions #803

merged 1 commit into from
Feb 15, 2017

Conversation

nicksnyder
Copy link
Contributor

because they are used in an exported function.

These paths caused me problems when I was trying to pursue method 1 in microsoft/vscode#20623

[17:13:16] Starting 'watch-client'...
[17:14:20] Error: /Users/nick/code/vscode/extensions/vscode-go/src/goOutline.ts(37,42): Parameter 'options' of exported function has or is using private name 'GoOutlineOptions'.
[17:14:20] Error: /Users/nick/code/vscode/extensions/vscode-go/src/goOutline.ts(37,69): Return type of exported function has or is using private name 'GoOutlineDeclaration'.

because they are used in an exported function.
@msftclas
Copy link

Hi @nicksnyder, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@ramya-rao-a ramya-rao-a merged commit e2f2acf into microsoft:master Feb 15, 2017
@nicksnyder nicksnyder deleted the exports branch February 15, 2017 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants