Add ability to collect traces and log errors to log file

README.md

@@ -86,6 +86,8 @@ Set `go.useLanguageServer` to `true` to use the Go language server from [Sourceg
 * This is an experimental feature and is not available in Windows yet.
 * If set to true, you will be prompted to install the Go language server. Once installed, you will have to reload VS Code window. The language server will then be run by the Go extension in the background to provide services needed for the above mentioned features.
 * Everytime you change the value of the setting `go.useLanguageServer`, you need to reload the VS Code window for it to take effect.
+* To collect traces, set `"go.useLanguageServer": { "trace": true }`
+* To collect errors from language server in a logfile, set `"go.useLanguageServer": { "logfile": "path to a text file that exists" }`
 
 
 ### Linter

src/goMain.ts

@@ -35,20 +35,26 @@ import { clearCacheForTools } from './goPath';
 let diagnosticCollection: vscode.DiagnosticCollection;
 
 export function activate(ctx: vscode.ExtensionContext): void {
- let useLangServer = vscode.workspace.getConfiguration('go')['useLanguageServer'];
+ let langServerConfig = vscode.workspace.getConfiguration('go')['useLanguageServer'];
  let toolsGopath = vscode.workspace.getConfiguration('go')['toolsGopath'];
 
  updateGoPathGoRootFromConfig().then(() => {
  offerToInstallTools();
  let langServerAvailable = checkLanguageServer();
  if (langServerAvailable) {
+ let langServerArgs = ['-mode=stdio'];
+ if (typeof langServerConfig !== 'boolean' && langServerConfig.hasOwnProperty('trace') && langServerConfig['trace'] === true) {
+ langServerArgs.push('-trace');
+ }
+ if (typeof langServerConfig !== 'boolean' && langServerConfig.hasOwnProperty('logfile') && typeof langServerConfig['logfile'] === 'string') {
+ langServerArgs.push('-logfile');
+ langServerArgs.push(langServerConfig['logfile']);
+ }
  const c = new LanguageClient(
  'go-langserver',
  {
  command: getBinPath('go-langserver'),
- args: [
- '-mode=stdio'
- ],
+ args: langServerArgs,
  },
  {
  documentSelector: ['go'],
@@ -143,15 +149,15 @@ export function activate(ctx: vscode.ExtensionContext): void {
 
  // If there was a change in "useLanguageServer" setting, then ask the user to reload VS Code.
  if (process.platform !== 'win32'
- && useLangServer !== updatedGoConfig['useLanguageServer']
+ && didLangServerConfigChange(langServerConfig, updatedGoConfig['useLanguageServer'])
  && (!updatedGoConfig['useLanguageServer'] || checkLanguageServer())) {
  vscode.window.showInformationMessage('Reload VS Code window for the change in usage of language server to take effect', 'Reload').then(selected => {
  if (selected === 'Reload') {
  vscode.commands.executeCommand('workbench.action.reloadWindow');
  }
  });
  }
- useLangServer = updatedGoConfig['useLanguageServer'];
+ langServerConfig = updatedGoConfig['useLanguageServer'];
 
  // If there was a change in "toolsGopath" setting, then clear cache for go tools
  if (toolsGopath !== updatedGoConfig['toolsGopath']) {
@@ -319,4 +325,18 @@ function sendTelemetryEventForConfig(goConfig: vscode.WorkspaceConfiguration) {
  useLanguageServer: goConfig['useLanguageServer'] + '',
  includeImports: goConfig['gotoSymbol'] && goConfig['gotoSymbol']['includeImports'] + ''
  });
+}
+
+function didLangServerConfigChange(oldConfig: vscode.WorkspaceConfiguration, newconfig: vscode.WorkspaceConfiguration) {
+ let oldType = typeof oldConfig;
+ let newType = typeof newconfig;
+ if (oldType === 'boolean' && newType === 'boolean') {
+ return oldConfig !== newconfig;
+ }
+
+ if (oldType === 'boolean' || newType === 'boolean') {
+ return true;
+ }
+
+ return (oldConfig['trace'] !== newconfig['trace'] || oldConfig['logfile'] !== newconfig['logFile']) ;
 }