Fix: add bsp dispose method (#1543)

microsoft · Aug 1, 2024 · 2a631cb · 2a631cb
1 parent 7f2f6d6
commit 2a631cb
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/extension/src/bs/BspProxy.ts b/extension/src/bs/BspProxy.ts
@@ -86,4 +86,10 @@ export class BspProxy {
             // TODO: Implement more specific error handling logic here
         });
     }
+
+    public closeConnection(): void {
+        this.buildServerConnector.close();
+        this.jdtlsImporterConnector.close();
+        this.logger.info("Build Server connection closed");
+    }
 }
diff --git a/extension/src/bs/BuildServerConnector.ts b/extension/src/bs/BuildServerConnector.ts
@@ -34,4 +34,10 @@ export class BuildServerConnector {
     public getServerPipePath(): string {
         return this.serverPipePath;
     }
+
+    public close(): void {
+        this.serverConnection?.end();
+        this.serverConnection?.dispose();
+        this.serverPipeServer.close();
+    }
 }
diff --git a/extension/src/bs/JdtlsImporterConnector.ts b/extension/src/bs/JdtlsImporterConnector.ts
@@ -68,4 +68,10 @@ export class JdtlsImporterConnector {
     public getImporterConnection(): rpc.MessageConnection | null {
         return this.importerConnection;
     }
+
+    public close(): void {
+        this.importerConnection?.end();
+        this.importerConnection?.dispose();
+        this.importerPipeServer.close();
+    }
 }
diff --git a/extension/src/server/GradleServer.ts b/extension/src/server/GradleServer.ts
@@ -88,6 +88,7 @@ export class GradleServer {
                 this._onDidStop.fire(null);
                 this.ready = false;
                 this.process?.removeAllListeners();
+                this.bspProxy.closeConnection();
                 if (this.restarting) {
                     this.restarting = false;
                     await this.start();
@@ -163,6 +164,7 @@ export class GradleServer {
     }
 
     public async asyncDispose(): Promise<void> {
+        this.bspProxy.closeConnection();
         this.process?.removeAllListeners();
         await this.killProcess();
         this.ready = false;