Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Bash: 3.11.0 #1191

Closed
3 tasks done
Tracked by #903
CsCherrYY opened this issue Feb 28, 2022 · 3 comments
Closed
3 tasks done
Tracked by #903

Bug Bash: 3.11.0 #1191

CsCherrYY opened this issue Feb 28, 2022 · 3 comments
Labels
eng engineering work
Milestone

Comments

@CsCherrYY
Copy link
Collaborator

CsCherrYY commented Feb 28, 2022

cc: @Eskibear
Test project: https://github.com/spring-projects/spring-petclinic

steps to verify:

  1. Open the spring-petclinic project
  2. Open Gradle projects view, double click a specific task
  3. Can see the task executing

steps to verify:

  1. Open the spring-petclinic project
  2. change setting java.jdt.ls.java.home to a specific jdk path and keep java.import.gradle.java.home being unset
  3. after reloading window, open Gradle projects view, check the output channel named Gradle for Java, can see a log with the following format:

[info] Java Home: ${your configured jdk path in java.jdt.ls.java.home}

  1. change setting java.import.gradle.java.home to a different jdk from the one in java.jdt.ls.java.home
  2. Click refresh button in the Gradle projects view, check the output channel named Gradle for Java, can see a log with the following format:

[info] Java Home: ${your configured jdk path in java.import.gradle.java.home}

steps to verify:

  1. Open the spring-petclinic project
  2. In Gradle Side Bar view, can see there is no Pinned Tasks view
  3. Right click the test task from verification task configuration, choose Pin Task
  4. Can see a new tasks folder under the same project in the view, named Pinned Tasks
  5. Can find the task just pinned in this folder
  6. Right click the pinned task, can see the following buttons:
  • Run Task (With Args)
  • Debug Task (With Args)
  • Pin Task With Args
  • Unpin Task
  • Open build file
@CsCherrYY CsCherrYY added the eng engineering work label Feb 28, 2022
@Eskibear
Copy link
Member

Eskibear commented Mar 1, 2022

Verified.

Click refresh button in the Gradle projects view

Yes, only after I click refresh, the new jdk is shown in logs. But I do see some logs generated once I changed the settings. I believe you've already listened to the settings change. So why not make it automatic?

@CsCherrYY
Copy link
Collaborator Author

previously there was a bug about not showing view content, see #903, the root cause is two refresh requests having race condition will cause empty result of vscode.TreeView.getChildren(). It's an upstream issue: microsoft/vscode#129019

So in #917 we just use a workaround to solve that issue, simplify remove the refresh() hook when the client connects to the server, that also results in the non-automatic refresh when reconnecting the server. Now I see the upstream issue has been resolved and I just tried and found it works.

@Eskibear My suggestion here is that we can roll back the workaround in #917 in develop branch and let it in the pre-release version to see if this error still exists or not. For the stable version, we can release it this time without the roll back and keep monitoring the pre-release version.

@Eskibear
Copy link
Member

Eskibear commented Mar 1, 2022

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng engineering work
Projects
None yet
Development

No branches or pull requests

2 participants