fix: Roll back onDidConnect hook #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsCherrYY
requested review from
Eskibear,
jdneo and
testforstephen
as code owners
|
Is it working with latest vscode now? Better try it by yourself before merging it. |
Eskibear
approved these changes
Apr 21, 2022
Yeah, I did a test with latest vscode and it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial comment: #1191 (comment). We'd better refresh the view after re-connecting to the server.
In #903 we just remove this hook for refreshing after the client connected to the server, for a VS Code upstream bug: microsoft/vscode#129019. Now the bug is fixed, and we can consider to rollback this change to see if the issue in #903 will appear again. This change can be kept in pre-release versions for the feedback of developers and users.