-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3.16.0 does not work any more #1546
Comments
We are aware of this, working on a fix right now... |
Thanks, then I will wait for the next release version |
We just released 3.16.1 Please try it and let us know if it solves the problem. |
I think this needs to be reopened. This is NOT fixed for me. I am a Flutter developer incase that is relevant. |
@MonkeyDoDev Can you provide more information like logs, sample project, |
Hi @jdneo I'm a self-taught 'muddle alonger' and wouldn't have the foggiest how to provide you with a sample project i'm afraid. I don't receive any log feed at all when i open VS studio, but i get the popups shown in the provided screenshot. Notably, this was not a problem until i upgraded Flutter the other day to its latest version. |
@MonkeyDoDev Is there any output in the channel |
@jdneo yes i've attached that here incase it helps |
What's the version of extension And could you provide the settings you are using? |
@jdneo im using v 3.16.1 and the default settings (i didn't even realise there were settings to change) - I think the screenshot i've attached shows you the relevant settings but let me know if you mean something else ![]() |
Ok. What's the file content if you trigger |
@jdneo ive attached my user settings JSON here. The 'Open Workspace Settings (JSON) is an empty file. |
Hello @jdneo
|
@abrod What if you set the setting |
@MonkeyDoDev The error in your screen shows that a JDK 11 is used to launch the gradle server. While in a recent change, we upgrade the gradle server compile target to jdk 17. In the implementation we have logic to search valid jdks (>17): vscode-gradle/extension/src/util/config.ts Lines 65 to 69 in 2a631cb
|
@jdneo ahh... it seems i simply needed to update the JDK on my machine to version 17 from the oracle website. Fixed now. Thanks for the help |
@MonkeyDoDev Good to know the issue is fixed. Though ideally, the gradle server should not be launched if no jdk 17 is found. This indicates that something wrong with the jdk detection logic. Filed an issue for further investigation: #1551 |
@jdneo I need to build a project with Gradle 6.8 and Java 11, similar to @abrod. |
@geoplan-junghak Did you install |
@jdneo Yes, I installed it. |
Hello @jdneo System Environment:
UserSettings (JSON)
so default jdk for vscode is 17 .vscode/settings.json:
this is needed for the build of the gradle file (because we use gradle 5) Output of version 3.16.1
Output of version 3.15.0
|
Should be fixed by #1552 Will schedule a pre-release soon |
Please try the pre-release version Let me know if the issue still exist. |
The build was successfully completed without errors using version v3.16.2024080209 (pre-release).
Thank you for your help. |
I used the prerelease version v3.16.2024080209 (pre-release) and the output was successful
Thanks a lot ... then I will wait for the next release version. |
Fixed by #1552 |
3.16.2 has been released with the fix |
@jdneo I am experiencing a similar issue upon upgrading from 3.15.0 to 3.16.2. I am running a project using openjdk-8 and in v3.15.0, without needing to set java.import.gradle.java.home, openjdk-8 is automatically selected as my "Java Home": but now in 3.16.2 I have to configure java.import.gradle.java.home, otherwise "Java Home" is set to: Which in my case will not download gradle version 6.8.3. In both cases JavaSE-1.8 is configured with the Language Support For Java extension. Wondering why this additional configuration is required now as it was previously being handled correctly? |
Recently, the runtime requirement for the extension is bumped to jdk 17. The extension will first find a jdk 17 used to launch the gradle server. Unfortunately, the Gradle tooling API will use the jdk that launches it as the java home. |
Extension Name: vscode-gradle
Extension Version: 3.16.0
OS Version: Windows
VSCode version: 1.91.1
JAVA_HOME: C:\Program Files\java\openjdk-11
Describe the bug
When I start VSCode the following 2 errors pop up:
But reloading did not help. A also tried a new installation and deleted the ~/.vscode and ~/AppData/Roaming/Code folder
To Reproduce
This happens on my computer, with the following files:
Expected behavior
This should work as in version 3.15.0
Screenshots
No screenshots
Output from "Gradle for Java"
[info] [gradle-server] ERROR: JAVA_HOME is set to an invalid directory: /C/Program Files/java/openjdk-8
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.
[warn] [gradle-server] Gradle server stopped
[error] Error connecting to gradle server: The channel has been closed
[error] The client has state: SHUTDOWN
Does the bug still exist if you disable all other extensions?
Moving to the previous version 3.15.0 helps (as a workarround)
Additional context
I have to continue with these old version gradle 5, java 8
The text was updated successfully, but these errors were encountered: