feat: Resolve custom task #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsCherrYY
force-pushed
the
cs-issue995
branch
from
47bb8e7 to
46f1914
Compare
CsCherrYY
commented
Nov 18, 2021
| @@ -205,6 +206,72 @@ export function createTaskFromDefinition( | |||
| return task; | |||
| } | |||
|
|
|||
| export function resolveTaskFromDefinition( | |||
There was a problem hiding this comment.
Here just copy the main logics from createTaskFromDefinition and use CustomExecution to resolve the VSCode variables
testforstephen
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #995
This PR separates create and resolve process of vscode tasks, in the resolving process, we can resolve
${}variables by passing them to CustomExecution.