Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Task and its pinned version not synchronized #1264

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Conversation

CsCherrYY
Copy link
Collaborator

fix #1245

before:

1245before.mp4

after:

1245after.mp4

@CsCherrYY CsCherrYY added the bug Something isn't working label Aug 9, 2022
@CsCherrYY CsCherrYY added this to the Augest 2022 milestone Aug 9, 2022
@Eskibear
Copy link
Member

Eskibear commented Aug 9, 2022

LGTM but when do/will you clear the mapping? (E.g. if I unpin some tasks.)

@CsCherrYY
Copy link
Collaborator Author

CsCherrYY commented Aug 9, 2022

LGTM but when do/will you clear the mapping? (E.g. if I unpin some tasks.)

We should clear the map as well in reset function. When you unpin a task, the view is refreshed, and the reset method will also be called.

@CsCherrYY CsCherrYY merged commit e3992ea into develop Aug 9, 2022
@CsCherrYY CsCherrYY deleted the cs-issue1245 branch August 9, 2022 06:51
@CsCherrYY
Copy link
Collaborator Author

To verify:

  1. git clone https://github.com/spring-projects/spring-petclinic
  2. open in VS Code and wait for project imported
  3. find task "bootRun" in Gradle projects view -> Tasks -> application group
  4. right click "bootRun" task and pin it
  5. add a breakpoint in main method of PetClinicApplication class
  6. right click "bootRun" task and choose "debug task", the debug session will stop at the breakpoint
  7. check the status of "bootRun" task in both applicaiton group and pinned group, the status are consistent and correct
  8. can stop the task from the item in pinned group.

@Eskibear
Copy link
Member

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task and its pinned version not synchronized
2 participants