Add support for subfolder gradle projects

[gayanper]

In the multi module setup where the parent folder is open by vscode, when wrapper is enabled, the LS fails the resolved the wrapper since it looks in workspace folder which is the root folder of the multi module project structure. The wrapper folders are actually in leaf level folders where the gradle files are found. So this fix try to resolve wrapper consider the current gradle file path to resolve it first, if that fails it falls back to workspace folder as before.

[gayanper]

@jdneo @testforstephen WDYT ?

[jdneo]

@gayanper I'll take a look recently. To help me understand the case that this PR fixes, could you share a screenshot showing the folder structure of the workspace we are talking about?

[testforstephen]

In the multi module setup where the parent folder is open by vscode, when wrapper is enabled, the LS fails the resolved the wrapper since it looks in workspace folder which is the root folder of the multi module project structure.

If the language server failed to locate the correct wrapper, the fix should be applied in eclipse.jdt.ls as well. jdt.ls has its own logic for finding the gradle distribution. This repo vscode-repo is an independent project and does not interact with jdt.ls.

[gayanper]

If the language server failed to locate the correct wrapper, the fix should be applied in eclipse.jdt.ls as well. jdt.ls has its own logic for finding the gradle distribution. This repo vscode-repo is an independent project and does not interact with jdt.ls.

jdt.ls works without issues. The reason might be the project import er traverse the folder structure to find gradle files recursively. And those found paths are used by gradle eclipse tooling to import projects into workspace.

[gayanper]

@gayanper I'll take a look recently. To help me understand the case that this PR fixes, could you share a screenshot showing the folder structure of the workspace we are talking about?

If i open the gradle-spring folder, the language server only provides the basic closures. But if i open the demo folder inside the gradle-spring then all plugin closures are provided.

[jdneo]

I tried to open workspace contains gradle project in a subfolder, but it does not give me completion for a jacoco closure. Do I miss anything?

gradle.mp4

[gayanper]

@jdneo when this issues happens you won't get inbuilt gradle plugin completions even. For example java, test and also dependency and different dependency configuration completions.

Could you try on those with and without fix on same setup?

[jdneo]

Not sure if it is due to something wrong with my local setup. I'll ask @CsCherrYY later.

[gayanper]

Without the fix
https://github.com/microsoft/vscode-gradle/assets/7471994/6eedf5ba-602d-4afa-bd8c-d975ee39bc67

[gayanper]

With the Fix
https://github.com/microsoft/vscode-gradle/assets/7471994/0cd7139e-7011-42e2-963e-6c87f7f21f1f

[gayanper]

@jdneo hope the above screenshots makes it more clear

[gayanper]

@jdneo @testforstephen I would say if we support multi-root workspace folders, then we should try to fix this. I found few more such extension which doesn't work in the way i explained above. I think vscode expect to use multi-root workspace folders in such situations like this https://medium.com/rewrite-tech/visual-studio-code-tips-for-monorepo-development-with-multi-root-workspaces-and-extension-6b69420ecd12

[gayanper]

@jdneo @testforstephen I would say if we support multi-root workspace folders, then we should try to fix this. I found few more such extension which doesn't work in the way i explained above. I think vscode expect to use multi-root workspace folders in such situations like this https://medium.com/rewrite-tech/visual-studio-code-tips-for-monorepo-development-with-multi-root-workspaces-and-extension-6b69420ecd12

We can close this if you also agree, The extension works as it is with multi-root workspaces.

[jdneo]

I would say if we support multi-root workspace folders, then we should try to fix this.

Yes, I agree.

Today I tried to setup the project on another machine and now everything works as expected. Not sure what's wrong happened days ago...

[jdneo]

Overall, the change looks good to me. I found another problem when trying the change, but that's another problem which we can address in another PR in the future.

---

Update: There is already an issue tracking this problem. #1237

[jdneo]

@gayanper I think this PR can be merged after the variable name changes. :)

[jdneo]

Thank you @gayanper