Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Reuse built extension on tests #1438

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

JoseLion
Copy link
Contributor

As discussed in #1419:

A better way to run CI is to build the extension and test it on different Java versions. We can leverage the artifacts already built on the build-and-analyse job to do that. We upload the required artifacts of the built extension and then download them to be reused on the test-extension job.

@jdneo
Copy link
Member

jdneo commented Oct 23, 2023

Looks like the errors are different on different platform. Some path related issues.

On windows, it's ENOENT: no such file or directory, mkdir 'D:\a\vscode-gradle\vscode-gradle\extension\lib

On Mac/Linux, it's chmod: cannot access 'extension/lib/gradle-server': No such file or directory.

@JoseLion
Copy link
Contributor Author

Yes, I misunderstood the documentation of the download-artifact action, so it was downloading in the incorrect path. I pushed a commit with a fix 🙂

@JoseLion
Copy link
Contributor Author

One more thing's missing 😅 even though we don't need to run ./gradlew extension:build anymore, we still need to install NPM dependencies in the test-extension job. I'll push a fix for that too 🙂

@jdneo jdneo added this to the 3.13.2 milestone Oct 24, 2023
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! It's not an easy task to update such a complex build description file.

Thank you for the contribution!

@jdneo jdneo merged commit cb3849c into microsoft:develop Oct 24, 2023
14 checks passed
@jdneo jdneo added the eng engineering work label Oct 24, 2023
@JoseLion JoseLion deleted the chore/ci-reuse-built-extension branch October 24, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng engineering work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants