Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: stop start build server when getRandomPipepath return empty #1545

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Fix: stop start build server when getRandomPipepath return empty #1545

merged 7 commits into from
Aug 2, 2024

Conversation

Jiaaming
Copy link
Contributor

@Jiaaming Jiaaming commented Aug 1, 2024

No description provided.

@jdneo
Copy link
Member

jdneo commented Aug 1, 2024

Please also consider handle the connection error in java side. Use isResolved() to skip importing from gradle build server

Jiaaming
Jiaaming commented Aug 2, 2024
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
jdneo
jdneo reviewed Aug 2, 2024
View reviewed changes
extension/src/bs/BspProxy.ts Outdated Show resolved Hide resolved
@jdneo jdneo added this to the 3.16.2 milestone Aug 2, 2024
@jdneo jdneo added the bug Something isn't working label Aug 2, 2024
@jdneo jdneo merged commit 4b505ad into microsoft:develop Aug 2, 2024
8 checks passed
@Jiaaming Jiaaming deleted the fix-get-pipepath-empty branch August 2, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

@testforstephen testforstephen Awaiting requested review from testforstephen testforstephen is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.16.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiaaming @jdneo