Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested projects extension activate #737

Merged
merged 4 commits into from
Oct 7, 2020
Merged

Conversation

badsyntax
Copy link
Collaborator

Fixes #724

  • Now no longer "activates" when there are nested projects but no corresponding config
  • Correctly "activate" and "deactivate" when changing the nestedProjects config

- Now no longer "activates" when there are nested projects but no corresponding config
- Correctly "activate" and "deactivate" when changing the nestedProjects config
Not happy with this logic
@badsyntax badsyntax force-pushed the fix-nested-activate branch from a2128bf to 8780626 Compare October 7, 2020 19:17
@badsyntax badsyntax force-pushed the fix-nested-activate branch from 8780626 to 413bd19 Compare October 7, 2020 19:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@badsyntax badsyntax merged commit 45f6179 into master Oct 7, 2020
@badsyntax badsyntax deleted the fix-nested-activate branch October 7, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The extension is activated when a *nested* gradle wrapper is found
1 participant