Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initialize Language Server #959

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

CsCherrYY
Copy link
Collaborator

This PR just initialize the feature branch of Gradle Authoring support. Related issue #956

This PR includes

  • A new language config: gradle (using language-configuration.json from vscode-java)
  • A gradle language Server based on lsp4j, with basic text document management service. (No feature included)
  • VSCode task to launch & debug the gradle language server. (production mode is the same as launch mode)

@CsCherrYY CsCherrYY added this to the 3.8.0 milestone Aug 29, 2021
@CsCherrYY CsCherrYY added the enhancement New feature or request label Aug 29, 2021
@CsCherrYY CsCherrYY changed the title feat: Init Language Server feat: Initialize Language Server Aug 29, 2021
@CsCherrYY CsCherrYY mentioned this pull request Aug 29, 2021
7 tasks
@@ -0,0 +1,78 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it copied from groovy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copied from vscode-java and checked.

I found another groovy def in code-groovy but the block comment in that file is <%--, --%>. The official groovy document is in https://docs.groovy-lang.org/next/html/documentation/#_multiline_comment and it's /*, */ , I'm not sure if it's for gsp(Groovy Server Pages) So I didn't use it.

For the snippets, I think they are common so we can start from it, and add more in the future if needed.

@@ -0,0 +1,94 @@
/*******************************************************************************
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you haven't implemented services, what's this file for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a standalone file manager to hold the contents of the opening files. Should it be removed from this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to be introduced from the PR related to corresponding features, for easier & clearer reviewing these features later...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I'm ok with it. just make sure to avoid unnessary I/O when you implementing them later.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@CsCherrYY CsCherrYY merged commit 92207e5 into cs-authoring-branch Aug 30, 2021
@CsCherrYY CsCherrYY deleted the cs-language-server branch August 30, 2021 02:44
CsCherrYY added a commit that referenced this pull request Sep 6, 2021
CsCherrYY added a commit that referenced this pull request Sep 23, 2021
CsCherrYY added a commit that referenced this pull request Sep 26, 2021
* feat: Initialize Language Server (#959)

* feat: Support compiling and pushing diagnostics (#962)

* feat: Support basic groovy syntax highlighting (#960)

* feat: Support semantic highlighting (#967)

* feat: Support document outline (#969)

* feat: Support auto completion in dependencies closure (#970)

* feat: Support Basic Auto Completion (#971)

* fix: Add null check for visitors (#974)

* feat: Show symbol detail for method calls (#973)

* chore: Prepare for 3.8.0 (#978)

* fix: Use padding to correct version order (#986)

* fix: Dependency completion doesn't work when multiple dependencies closures exist (#984)

* fix: Correct version completion kind (#985)

* fix: Handle multiple content changes (#992)

* feat: Support completion for settings.gradle (#988)

* fix: Offer completion results from supertypes (#987)

* feat: Provide dependencies content in outline (#998)

* feat: Support basic java plugin aware (#989)

* feat: Support basic tasks and dependencies (#1002)

* chore: Add thirdpartynotice

* chore: Fix ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants