Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header colors are too loud #132

Open
Tyriar opened this issue Jul 24, 2020 · 2 comments
Open

Header colors are too loud #132

Tyriar opened this issue Jul 24, 2020 · 2 comments
Labels
styling Issues relating to the styling (CSS)

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 24, 2020

Testing microsoft/vscode#103174

Topaz (Dim) theme, the bright yellow is used sparingly in the theme but it's all over the place in the hex editor.

image
@lramos15
Copy link
Member

Any suggestions for color tokens, currently using --vscode-editorLineNumber-activeForeground

@lramos15 lramos15 added the styling Issues relating to the styling (CSS) label Jul 24, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Jul 24, 2020

Well you should probably be using --vscode-editorLineNumber-activeForeground for the active line? I think earlier I suggested the color for the views as they would normally be fairly muted:

image

Tyriar added a commit that referenced this issue Mar 17, 2021
@Tyriar
Remove data inspector header, improve panel name
4b29a55 
Part of #132
Part of #223
@Tyriar Tyriar mentioned this issue Mar 17, 2021
Merged
Tyriar added a commit that referenced this issue Mar 17, 2021
@Tyriar
Remove data inspector header, improve panel name (#252)
26518ca 
* Remove data inspector header, improve panel name

Part of #132
Part of #223

* Add back missing when
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
styling Issues relating to the styling (CSS)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @lramos15