Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect the editor.scrollBeyondLastLine setting #329

Closed
Tyriar opened this issue Jan 4, 2022 · 0 comments · Fixed by #398
Closed

Respect the editor.scrollBeyondLastLine setting #329

Tyriar opened this issue Jan 4, 2022 · 0 comments · Fixed by #398
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 4, 2022

Right now it seems that scrolling stops in the middle of the screen which is sort of in-between the two options available in the editor. We should scroll to show the last line at the top when editor.scrollBeyondLastLine=true or the last line at the bottom when editor.scrollBeyondLastLine=false
@connor4312 connor4312 added the feature request Issues related to new features users want label Dec 9, 2022
connor4312 added a commit that referenced this issue Dec 10, 2022
@connor4312
fix: respect editor.scrollBeyondLastLine
dd032b2 
Fixes #329
@connor4312 connor4312 self-assigned this Dec 10, 2022
@connor4312 connor4312 added this to the December 2022 milestone Dec 10, 2022
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug and removed feature request Issues related to new features users want labels Dec 10, 2022
@connor4312 connor4312 mentioned this issue Dec 10, 2022
Merged
connor4312 added a commit that referenced this issue Dec 10, 2022
@connor4312
fix: respect editor.scrollBeyondLastLine (#398)
1a4fa3c 
Fixes #329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: respect editor.scrollBeyondLastLine microsoft/vscode-hexeditor
2 participants
@Tyriar @connor4312