-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Int24 incorrect for big-endianness #330
Labels
bug
Issue identified by VS Code Team member as probable bug
Comments
@paamand Thanks for the bug report and code pointer. If you want to create a PR to fix this problem let me know, otherwise I can go ahead and fix it. |
paamand
added a commit
to paamand/vscode-hexeditor
that referenced
this issue
Jan 10, 2022
Making explicit endian indexing of the adjacent bytes and explicit signed conversion.
Done. #331
Please review before merging ;) |
lramos15
pushed a commit
that referenced
this issue
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The byte-order is interpreted wrong for big-endian int24 and uint24.
When reading the sequence "80 00 80" the correct interpretation is given for little endian (i.e. -8388480 for int24, 8388736 for uint24) but wrong numbers are given for big endian (-32768 for int24, 8421376 for uint24).
The interpretation mixes up the two last bytes. I.e 8421376 is "80 80 00" instead of the input "80 00 80".
The problem is line 144 to 148 of /media/data_inspector/byteData.ts
The text was updated successfully, but these errors were encountered: