Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why cannot deletion be performed in editing? #466

Closed
suimodi opened this issue Nov 7, 2023 · 1 comment · Fixed by #476
Closed

Why cannot deletion be performed in editing? #466

suimodi opened this issue Nov 7, 2023 · 1 comment · Fixed by #476
Assignees
@connor4312
Labels
feature request Issues related to new features users want
Milestone
February 2024

Comments

@suimodi
Copy link

suimodi commented Nov 7, 2023

Could you please add the delete function
@nabelekt
Copy link

+1 Seems like an obvious oversight

connor4312 added a commit that referenced this issue Feb 1, 2024
@connor4312
fix: improve range selection logic, support delete
d359574 
It was a long time on my todo to fix the "publishSelections", as it was
previously linear time with the _number of bytes_ selected -- not the best.

Once I fixed that, supporting deletions was fairly trivial, although it
is handled a little differently than other edits...

Closes #466
@connor4312 connor4312 mentioned this issue Feb 1, 2024
Merged
@connor4312 connor4312 self-assigned this Feb 1, 2024
@connor4312 connor4312 added this to the February 2024 milestone Feb 1, 2024
@connor4312 connor4312 added the feature request Issues related to new features users want label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
feature request Issues related to new features users want
Projects
None yet
Milestone
February 2024
Development

Successfully merging a pull request may close this issue.

fix: improve range selection logic, support delete microsoft/vscode-hexeditor
3 participants
@connor4312 @nabelekt @suimodi