Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor should be responsive #6

Closed
joaomoreno opened this issue Jun 2, 2020 · 3 comments
Closed

Editor should be responsive #6

joaomoreno opened this issue Jun 2, 2020 · 3 comments
Assignees
Labels
UI/UX Issues regarding the UI or the UX of the extension

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jun 2, 2020

Testing microsoft/vscode#98980

It seems to require quite a wide editor for everything to fit:

image

@FabianoGK
Copy link

Since this issue seems to be related to the style of the editor window, I would like to suggest:

  1. removing the word "Memory" from "Memory Offset";
  2. move "Data Inspector" panel to the right;
  3. allow "Data Inspector" panel to be collapsed;
  4. reduce padding around characters on the "Decoded Text" panel;
  5. have another dropdown on "Data Inspector" to adjust the base for all integer numbers (dec/hex/oct/bin);
  6. have a way to configure how many bytes to show per line.

HxD is really great at allowing any number of bytes per line. It even has the ability to adapt the number of bytes per line to fit the width of the window.

The other suggestions were also inspired on HxD features.

@lramos15 lramos15 added enhancement UI/UX Issues regarding the UI or the UX of the extension labels Jun 11, 2020
@antoniovazquezblanco
Copy link

Here I would like to add my two cents, I hope it helps:

  • At first the hex editor is a bit weird because it colapses the file tree view while the text editor does not do that. I would suggest trying to mimick the default behaviour of the text editor and not collapse the lateral view unless the user explicitly does so...
  • I really agree with @FabianoGK when talking about reducing extra words: "Memory Offset" -> "Offset" would be great.
  • I would panelize the "Data inspector". Maybe converting it to a panel that could be moved to the bottom (same as the console) or to a side or customizing where it can be placed helps with the issue of fitting multiple sized screens... Maybe one could even think of a lateral button like VCS does but this seems less intuitive for myself.
  • Integrate with the native search funciton maybe. I don't know if this is possible but it would be awesome to be able to integrate with the native search solutions instead of you having to implement your own...

@connor4312
Copy link
Member

We've since change the editor design a bit. The Data Inspector turns in a hover on narrow screens, and the width of the inspector is customizable (though we don't want the width to be 'responsive' since the number of bytes per row is important)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Issues regarding the UI or the UX of the extension
Projects
None yet
Development

No branches or pull requests

5 participants