-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Hex Editor Extension #98980
Comments
This totally fails for me due to eb09996 Also, maybe instead of giving us a ZIP, let us just clone the repo, build it, so we test what's on latest. |
I'll have to ask @mjbvz what changed. We tested it yesterday and it was working, but I believe he was doing some API work after I got off. I figured a VSIX would be easier than compiling from sources. It doesn't compile from sources anymore either. The VSIX is up to date with latest. |
I have updated the VSIX by using the types from sources as we're in this weird limbo where they're not in proposed, but not in the shipped types just yet. The VSIX should work and you no longer need the proposed API flag. Let me know if it doesn't. |
It works as documented above. The only concern I have is the scrolling performance, especially when using mouse/trackapd and blank frames are fairly easy to see. |
whoops, sorry. accidentally closed it 🙈 |
+1 to @rebornix 's comment from me too. |
#98105
Complexity: 4
Author: @lramos15
Create Issue
Testing Steps:
hexeditor-1.0.0.zip (Just change the .zip to .vsix)
Just overall ensure the editor feels natural to use and everything is working how you would expect it to.
The text was updated successfully, but these errors were encountered: