Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Hex Editor Extension #98980

Closed
3 tasks done
lramos15 opened this issue Jun 1, 2020 · 6 comments
Closed
3 tasks done

Test: Hex Editor Extension #98980

lramos15 opened this issue Jun 1, 2020 · 6 comments

Comments

@lramos15
Copy link
Member

lramos15 commented Jun 1, 2020

#98105

Complexity: 4
Author: @lramos15

Create Issue


Testing Steps:

  1. Install this VSIX
    hexeditor-1.0.0.zip (Just change the .zip to .vsix)
  2. Test opening various files as hex via the reopen with dialog / setting the hex editor as your default editor for that file type.
  3. Test arrow key navigation, scrolling, clicking etc within the editor.
  4. Test changing the endianness of the Data inspector.
  5. Try changing the maxFileSize setting and ensuring it warns you for files over the maxFileSize you have specified.

Just overall ensure the editor feels natural to use and everything is working how you would expect it to.

@joaomoreno
Copy link
Member

joaomoreno commented Jun 2, 2020

This totally fails for me due to eb09996

image

Also, maybe instead of giving us a ZIP, let us just clone the repo, build it, so we test what's on latest.

@lramos15
Copy link
Member Author

lramos15 commented Jun 2, 2020

I'll have to ask @mjbvz what changed. We tested it yesterday and it was working, but I believe he was doing some API work after I got off. I figured a VSIX would be easier than compiling from sources. It doesn't compile from sources anymore either. The VSIX is up to date with latest.

@lramos15
Copy link
Member Author

lramos15 commented Jun 2, 2020

I have updated the VSIX by using the types from sources as we're in this weird limbo where they're not in proposed, but not in the shipped types just yet. The VSIX should work and you no longer need the proposed API flag. Let me know if it doesn't.

@rebornix
Copy link
Member

rebornix commented Jun 2, 2020

It works as documented above. The only concern I have is the scrolling performance, especially when using mouse/trackapd and blank frames are fairly easy to see.

@9at8
Copy link
Member

9at8 commented Jun 2, 2020

whoops, sorry. accidentally closed it 🙈

@9at8
Copy link
Member

9at8 commented Jun 2, 2020

+1 to @rebornix 's comment from me too.

@joaomoreno joaomoreno removed their assignment Jun 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants