Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inspector sometimes saying end of file #241

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Fix inspector sometimes saying end of file #241

merged 1 commit into from
Mar 17, 2021

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 17, 2021

A check was setting 0 and null to NaN instead of just null

Fixes #232
Fixes #222

@Tyriar
Fix inspector sometimes saying end of file
113c580 
A check was setting 0 and null to NaN instead of just null

Fixes #232
Fixes #222
@Tyriar Tyriar added this to the March 2021 milestone Mar 17, 2021
@Tyriar Tyriar requested a review from lramos15 March 17, 2021 12:35
@Tyriar Tyriar self-assigned this Mar 17, 2021
lramos15
lramos15 approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. This has bit me before. Thanks for the fix 😃

@lramos15 lramos15 merged commit 20d7f85 into main Mar 17, 2021
@Tyriar Tyriar deleted the tyriar/eof branch March 17, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lramos15 lramos15 lramos15 approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
March 2021
Development

Successfully merging this pull request may close these issues.

Float 32 sometimes says "End of File" Uint8 and 8 bit binary don't work when the hex value is 0
2 participants
@Tyriar @lramos15