Implement editing, find/replace in streaming model #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
force-pushed
the
streaming-3
branch
from
bf37be5
to
9e249f9
Compare
lramos15
approved these changes
Nov 19, 2021
|
Fixed a bunch of those, the remainder I will take care of when I return Tuesday
The quickpick bug we hit is an easy repro and captured in microsoft/vscode#137558 |
This approach will not work, it's wildcards and not placeholders. But committing it if we need it in the future...
|
This should be good to go now. I'll write up a TPI over holiday. |
lramos15
pushed a commit
that referenced
this pull request
Nov 29, 2021
* fixup! comments * refactor: updates to webview side of things * initial working bytes display * data display and basic selection * get selection more up to snuff * finish data selection and display side * refactor: use custom state for selection to improve performance * tweaks * Implement editing, find/replace in streaming model (#316) * wip * fixup, get replacement editing working * unsaved ranges and go to offset * chore: remove dead code * feat: implement virtual scroll * wip * refactor: add comments and clean up math * find/replace * feat: undo/redo * fix: focus issues with go to offset quickpick * fix: focus back to the byte when hiding find widget * fix: binary in search, cap results by default for perf, progress * fix: don't change selected toolbar background on hover * fix: issues with length changes and large find/replace * feat: add replace toggle * feat: show better validation for find widget errors * feat: wip on string search with placeholders This approach will not work, it's wildcards and not placeholders. But committing it if we need it in the future... * feat: support placeholders in search * feat: persist webview state information * fix: make revert work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements editing, include find and replace. Undo/redo doesn't work, I'll toss that in tomorrow morning. After this I'll swap to some of my other iteration work.