feat: add inline data inspector #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old data inspector is preserved, but the new one is the default. It functions (and looks) like the standard widget in the editor, and basically just has information parity with the old sidebar inspector. 
connor4312
force-pushed
the
feat/inline-data-inspector
branch
from
ff7515c
to
91d32d0
Compare
|
I would like to discuss this in the UX sync prior to merging it as I don't love an endianness checkbox and would like others thoughts on this |
lramos15
requested changes
Feb 17, 2022
There was a problem hiding this comment.
Left a few comments. I still worry about the maintainability of the hex editor given that this 500 lines of changes doesn't add any comments. Even just general "this clears the tooltip when you click off" or "reveals the data inspector" would be greatly appreciated. Also wonder if we should add some tests for the data inspector given that it can now be in 3 locations we should make sure it works the same in all the various locations. Thanks for the change :)!
lramos15
reviewed
Feb 18, 2022
lramos15
reviewed
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old data inspector is preserved, but the new one is the default. It
functions (and looks) like the standard widget in the editor, and
basically just has information parity with the old sidebar inspector.