Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix inconsistencies in README and CONTRIBUTING #372

Merged
merged 1 commit into from
Aug 8, 2022
Merged

docs: fix inconsistencies in README and CONTRIBUTING #372

merged 1 commit into from
Aug 8, 2022

Conversation

jwr1
Copy link
Contributor

@jwr1 jwr1 commented Aug 6, 2022

While contributing, I noticed some outdated documentation:

  • yarn is no longer used.
  • esbuild is now used instead of webpack.
  • The data inspector has three different setups with aside being the new default.

@ghost
Copy link

ghost commented Aug 6, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

lramos15
lramos15 approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@lramos15 lramos15 merged commit e7a0f26 into microsoft:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpasero bpasero bpasero approved these changes

@lramos15 lramos15 lramos15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwr1 @bpasero @lramos15