fix tsc errors, and run it in prs too #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
commented
Nov 29, 2022
| }, | ||
| "devDependencies": { | ||
| "@babel/preset-react": "^7.18.6", | ||
| "@babel/preset-typescript": "^7.18.6", | ||
| "@linaria/esbuild": "^4.1.4", | ||
| "@linaria/shaker": "^4.2.1", | ||
| "@types/babel__core": "^7.1.20", |
There was a problem hiding this comment.
These were needed since Linaria's types reference them
There was a problem hiding this comment.
I wonder why linaria doesn't have it as a dependency then? I guess types cannot have dependencies
There was a problem hiding this comment.
It's always been kind of an annoying thing: you have types that expose stuff from another package, but you also don't want to mark that package as a 'production dependency' since it might not actually be used at runtime and therefore unnecessary for non-TypeScript consumers.
connor4312
commented
Nov 29, 2022
| }, | ||
| "dependencies": { | ||
| "@linaria/react": "^4.1.4", | ||
| "@popperjs/core": "^2.11.2", | ||
| "@popperjs/core": "^2.11.6", |
There was a problem hiding this comment.
2.11.2 had types that failed to compile in TS 4.9
lramos15
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.