-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add common cjk encoding (gb18030 for simple Chinese, big5 for traditional Chinese, euc-kr for Korean, euc-jp for Japanese) datatype support #465
Conversation
I do worry that this will make the data inspector fairly long. I wonder if there's a way we can support all the formats that the TextDecoder supports without adding a bunch of these |
Yeah, an interactive However, the datatype decode is quick and low resource consumption. And there are a lot remaining free spaces there, so maybe not a problem right now. |
Could you please also add Shift-JIS? I believe it's pretty common in a lot of JP executables. |
@HaxtonFale Hi, do you means |
From the docs on Encodings of Japanese. It seems And for Korean, |
change encoding for Korean from euc-kr to iso-2022-kr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add in some filtering logic after we merge this
IMHO, maybe it would be better to allow users to customize encoding(s) to use in configuration file? |
Closes #464.