Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compile errors #492

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix: compile errors #492

merged 2 commits into from
Feb 22, 2024

Conversation

rzhao271
Copy link
Contributor

No description provided.

@rzhao271
fix: compile errors
aef7cd6 
Fixes compile errors introduced by using the wrong variables
with the toString method
@rzhao271 rzhao271 self-assigned this Feb 22, 2024
@rzhao271 rzhao271 added this to the February 2024 milestone Feb 22, 2024
@rzhao271 rzhao271 marked this pull request as ready for review February 22, 2024 17:43
@rzhao271 rzhao271 enabled auto-merge (squash) February 22, 2024 17:43
andreamah
andreamah previously approved these changes Feb 22, 2024
View reviewed changes
Tyriar
Tyriar previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have CI to prevent this on this repo?

lramos15
lramos15 requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get CI for this, it's on the list.

Is there a way we can avoid the non null assertions?

@rzhao271
Copy link
Contributor Author

Updating TypeScript could help, though won't get to that for a bit.

@connor4312
Copy link
Member

We can just remove pr: none in the pipeline.yml to get checks for this

@rzhao271 rzhao271 dismissed stale reviews from Tyriar and andreamah via 6b23bea February 22, 2024 18:04
@lramos15 lramos15 merged commit 42a7f30 into main Feb 22, 2024
4 of 7 checks passed
@lramos15 lramos15 deleted the rzhao271/fix-build branch February 22, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@connor4312 connor4312 connor4312 approved these changes

@lramos15 lramos15 lramos15 approved these changes

@andreamah andreamah andreamah left review comments

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
February 2024
Development

Successfully merging this pull request may close these issues.
5 participants
@rzhao271 @connor4312 @Tyriar @lramos15 @andreamah