Fix: duplicate saving and stale webview. #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the duplicate save by saving only the timeline from the unsaved index. Fixed the duplicate insertion by only applying timeline from the unsaved index. Fixed bytes not showing after saving by forcing the webview to reload its raw data pages. Fixed diskFileSize state being updated with diskFileSize + editsDelta instead of only diskFileSize. Fixed diskFileSize state not being updated after document save. Added tests to triple check the fix works in all places that used the previous editTimeline. Changed editTimeline to AllEditTimeline to prevent confusion with the newly added unsavedEditTimeline
|
Thanks! |
connor4312
previously approved these changes
Apr 16, 2024
|
Hm, it looks like there's a test failure |
auto-merge was automatically disabled
April 16, 2024 19:27
Head branch was pushed to by a user without write access
connor4312
approved these changes
Apr 18, 2024
connor4312
reviewed
Apr 18, 2024
| } | ||
| return Promise.all( | ||
| ops.map(({ data, offset }) => { | ||
| return fd.write(data, 0, data.byteLength, offset); |
lramos15
approved these changes
Apr 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #511. Took me a bit of time to figure out everything, but I think the solution is working. I also added some tests to triple check the work.