Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doNotAddAttributeQuotes setting to disable automatic quotes #112

Merged
merged 3 commits into from
Sep 27, 2021

Conversation

ssigwart
Copy link
Contributor

  • For example, clas| completion will be class=| instead of class="|"

- For example, `clas|` completion will be `class=|` instead of `class="|"`
@aeschli aeschli merged commit 44727c3 into microsoft:main Sep 27, 2021
@aeschli
Copy link
Contributor

aeschli commented Sep 27, 2021

I changed to use an enum.
Thanks @ssigwart for the PR!

@aeschli aeschli self-assigned this Sep 27, 2021
@aeschli aeschli added this to the September 2021 milestone Sep 27, 2021
@ssigwart
Copy link
Contributor Author

Great. Thank you, @aeschli! Do you want me to make updates to microsoft/vscode#129284 to match the new version and updated config name?

@aeschli
Copy link
Contributor

aeschli commented Sep 29, 2021

@ssigwart I didn't find time to adopt microsoft/vscode#129284. If you want to, that would be great, otherwise I'll get to it next week.

@ssigwart ssigwart deleted the noQuotes branch September 30, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants