This repository has been archived by the owner on Apr 23, 2022. It is now read-only.
Show progress in the notification area when download codegen cli #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriolchan
reviewed
Dec 30, 2019
src/DigitalTwin/CodeGeneratorCore.ts
Outdated
| const tempPath = path.join(os.tmpdir(), FileNames.iotworkbenchTempFolder); | ||
| const filePath = path.join(tempPath, `${md5value}.zip`); | ||
| fs.writeFileSync(filePath, zipData); | ||
| // clearInterval(loading); |
There was a problem hiding this comment.
better to remove unused code here #Pending
There was a problem hiding this comment.
| progress.report({increment: 10, message: `still going...`}); | ||
| }, 1000); | ||
|
|
||
| setTimeout(() => { |
There was a problem hiding this comment.
Show the progress of the download progress of the CodeGen CLI, Similar to https://github.com/microsoft/vscode-extension-samples/tree/master/progress-sample
In reply to: 361902619 [](ancestors = 361902619)
eriolchan
approved these changes
Dec 30, 2019
xinyiz1226
approved these changes
Dec 30, 2019
dilin-MS
reviewed
Dec 30, 2019
src/DigitalTwin/CodeGeneratorCore.ts
Outdated
| if (hashvalue !== md5value) { | ||
| `the downloaded ${DigitalTwinConstants.codeGenCli} v${ | ||
| newVersion} package has been corrupted.`); | ||
| if (installOrUpgrade === 1) { |
There was a problem hiding this comment.
What does number 1 means here? Please use CodeGenCliOperation enum value to better illustrate the meaning.
xinyiz1226
approved these changes
Dec 31, 2019
…ft/vscode-iot-workbench into install-codegen-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.