This repository has been archived by the owner on Apr 23, 2022. It is now read-only.
Remove project path from telemetry and add hash project name #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilin-MS
requested review from
eriolchan,
dooriya,
xinyiz1226 and
JerryYangKai
xinyiz1226
approved these changes
Dec 31, 2019
eriolchan
reviewed
Dec 31, 2019
| * @param algorithm hash algorithm | ||
| */ | ||
| export function getHashFromString( | ||
| stringToHash: string, algorithm = 'md5'): string { |
There was a problem hiding this comment.
It is better to use sha256 instead of md5
dilin-MS
force-pushed
the
remove-projectpath
branch
from
bf3db92 to
de68ab1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.