Skip to content
This repository has been archived by the owner on Apr 23, 2022. It is now read-only.

Replace gts with eslint #908

Merged
merged 7 commits into from
Jan 13, 2020
Merged

Replace gts with eslint #908

merged 7 commits into from
Jan 13, 2020

Conversation

dilin-MS
Copy link
Contributor

@dilin-MS dilin-MS commented Jan 9, 2020

Replace gts with eslint and prettier.

Leave out views/ vendor/node-usb-native and assets/ folder since javascript files in these folder cause too many eslint error.
Delaying linting these files for the below three reasons:

  1. There are tons of eslint error in these files. Fixing them requires much work.
  2. Since changes are so many, it requires careful test. Or it will be error-prone.
  3. This part of code is relatively infrequently modified.

We can discuss later whether take time to fix eslint errors in these folders.

@dilin-MS dilin-MS force-pushed the add-eslint branch 2 times, most recently from e7d07bf to c4679fb Compare January 10, 2020 08:32
@dilin-MS dilin-MS requested a review from xinyiz1226 January 10, 2020 08:47
@dilin-MS dilin-MS force-pushed the add-eslint branch 2 times, most recently from 49f48b2 to c27c5f7 Compare January 13, 2020 07:50
.eslintrc.json Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
.vscode/settings.json Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/AzureOperator.ts Outdated Show resolved Hide resolved
src/DigitalTwin/pnp/src/api/apiProvider.ts Outdated Show resolved Hide resolved
src/DigitalTwin/pnp/src/common/utility.ts Show resolved Hide resolved
src/DigitalTwin/pnp/src/common/utility.ts Show resolved Hide resolved
@dilin-MS dilin-MS merged commit 65a7244 into develop Jan 13, 2020
@dilin-MS dilin-MS deleted the add-eslint branch January 13, 2020 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants