This repository has been archived by the owner on Apr 23, 2022. It is now read-only.
test: add test case for iot workbench settings #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriolchan
reviewed
Feb 25, 2020
test/IoTSettings.test.ts
Outdated
| const workbenchPathFromConfig = "workbench-path-from-config"; | ||
| const defaultWorkbenchPath = "default-workbench-path"; | ||
| configHandlerModule.ConfigHandler.get = jest.fn().mockReturnValueOnce(workbenchPathFromConfig); | ||
| IoTWorkbenchSettingsModule.IoTWorkbenchSettings.getDefaultWorkbenchPath = jest |
There was a problem hiding this comment.
Since we are testing IoTWorkbenchSettings class, I recommend not mocking its self method, but mocking external dependency (e.g. getPlatform and getHomeDir) instead, to get desired value.
test/IoTSettings.test.ts
Outdated
|
|
||
| test("set workbench path", async () => { | ||
| const userWorkbenchPath = "user-workbench-path"; | ||
| vscode.window.showQuickPick = jest |
There was a problem hiding this comment.
It seems the mocked "showQuickPick" method return the first item in your code, which is the default behavior defined in "mocks/vscode.js". You can remove this mocking statement to see if it works.
eriolchan
approved these changes
Feb 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.