Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to control whether to enable async jdwp #1208

Merged
merged 4 commits into from
Aug 31, 2022

Conversation

testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Aug 30, 2022

This PR relates to microsoft/java-debug#436

java.debug.settings.jdwp.async: Experimental: Controls whether the debugger is allowed to send JDWP commands asynchronously. Async mode can improve remote debugging response speed on high-latency networks. Defaults to auto, and automatically enable async mode in VS Code - Insiders.

  • auto (Default)
  • on
  • off

src/configurationProvider.ts Outdated Show resolved Hide resolved
@Eskibear
Copy link
Member

Will this setting appear on settings page for vscode stable editions? If so, shall we explicitly note "for Insiders only" also in this setting's description instead of "experimental" to avoid confusion? Because for stable vscode, I also see some native "experimental" settings that works.

@testforstephen
Copy link
Contributor Author

Will this setting appear on settings page for vscode stable editions? If so, shall we explicitly note "for Insiders only" also in this setting's description instead of "experimental" to avoid confusion? Because for stable vscode, I also see some native "experimental" settings that works.

This is not for Insiders only, just enable it on Insiders by default. For stable, you still can manually opt in.

@Eskibear
Copy link
Member

This is not for Insiders only, just enable it on Insiders by default. For stable, you still can manually opt in.

Sorry for misunderstanding. Then it looks good to me.

@testforstephen testforstephen merged commit 344022b into microsoft:main Aug 31, 2022
@testforstephen testforstephen deleted the jinbo_async branch August 31, 2022 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants