Refine the command to create Java project #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
force-pushed
the
cs/create-project
branch
from
0013de3 to
e95d6e6
Compare
Signed-off-by: Sheng Chen <sheche@microsoft.com>
jdneo
force-pushed
the
cs/create-project
branch
from
e95d6e6 to
7cca3bb
Compare
|
@Eskibear @testforstephen @akaroml Please take a look when you have time. The A/B testing work will be addressed in another PR, to avoid too much code change in one PR. |
Eskibear
reviewed
Apr 17, 2020
src/controllers/projectController.ts
Outdated
| if (contextManager.getContextValue(Context.MAVEN_ENABLED)) { | ||
| projectKinds.push({ | ||
| label: BuildTool.Maven, | ||
| detail: "Use Maven as the build tool of your Java project", |
There was a problem hiding this comment.
Apache Maven is a software project management and comprehension tool. Based on the concept of a project object model (POM), Maven can manage a project's build, reporting and documentation from a central piece of information.
so would something like "Use Maven to manage your project" be simple and concise?
Eskibear
reviewed
Apr 17, 2020
| }, | ||
| ); | ||
|
|
||
| switch (choice.label) { |
There was a problem hiding this comment.
choice is possible to be undefined, if you have more than one project kinds.
Eskibear
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #249
fix #206
fix #199